Improve pr-review skill: inline comments, thread resolution, and new checklist items#4425
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- eventSink must be passed as a direct lambda, not a local variable - navigator.pop() must be inside the launch block after async operations - Use Fakes instead of mockk for interfaces with @composable functions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4425 +/- ##
===========================================
- Coverage 51.99% 51.98% -0.01%
===========================================
Files 454 454
Lines 12075 12075
Branches 2092 2092
===========================================
- Hits 6278 6277 -1
Misses 5181 5181
- Partials 616 617 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventSinkmust be a direct lambda (not a local variable),navigator.pop()must be insidelaunch {}after async ops, and@Composableinterfaces must use hand-writtenFake*classes instead of mockkTest plan
/pr-reviewon an open PR and verify inline comments are posted🤖 Generated with Claude Code